-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
default-input: Catch errors from npa #71
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move `var spec` from inside `try` to outside.
Thanks for the approval @addaleax! Did the change you suggested. |
Well, not good, that I burst in this pull request, but It's usfull change, any status changing (merge/close)? |
I'm just waiting for a review from a maintainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks! This is a good thing to catch!
* default-input: Catch errors from npa * Move variable declaration Move `var spec` from inside `try` to outside.
* default-input: Catch errors from npa * Move variable declaration Move `var spec` from inside `try` to outside.
Thank you! |
@smashraid try updating |
Before:
After:
Catches errors from npa instead of letting them propagate